04-25-2015, 03:28 PM
For clarification, the mention of "Codecanyon recently released a notice regarding the fact that many of their plugins contain harmful code that can be used maliciously" is referring exactly to a practice which has gone on for years where developers weren't properly escaping when using:
WordPress had not fully explained the use of those functions in the Codex. Simply making a statement that WordPress plugins on Codecanyon are using "harmful code" is not exactly a correct statement.
The statement made by Envato is "This is a general community announcement to bring your attention to an XSS vulnerability affecting multiple WordPress plugins and themes." And they give links to sites explaining what that vulnerability is about.
There has been a major coordinated update which has been going on for about three days. Thousands of plugins have updated during that time in the WordPress Repository and Envato has been successfully getting plugin and theme developers to do updates as well.
Again, this is a vulnerability which has been present for years. But now it is in the process of being fixed globally.
The implication made that the plugin offered here might be one of those plugins and that "bimple" fixed it is false. The changed "code" in the alternate download on this thread has nothing to do with those vulnerabilities.
So, I will have to say that this plugin version is most likely still containing the XSS Vulnerability contrary to the claim by "bimple" of fixing and re-uploading it.
The claim by "bimple" of "I cleaned them and re-upped them.", no that didn't happen. The vulnerability is still there.
Code:
"add_query_arg() and remove_query_arg() functions".
The statement made by Envato is "This is a general community announcement to bring your attention to an XSS vulnerability affecting multiple WordPress plugins and themes." And they give links to sites explaining what that vulnerability is about.
There has been a major coordinated update which has been going on for about three days. Thousands of plugins have updated during that time in the WordPress Repository and Envato has been successfully getting plugin and theme developers to do updates as well.
Again, this is a vulnerability which has been present for years. But now it is in the process of being fixed globally.
The implication made that the plugin offered here might be one of those plugins and that "bimple" fixed it is false. The changed "code" in the alternate download on this thread has nothing to do with those vulnerabilities.
Code:
I will say that the add_query_arg() function is called 24 times in this plugin and none of them are correctly escaped either in the OP download or the alternate "corrected" files.
So, I will have to say that this plugin version is most likely still containing the XSS Vulnerability contrary to the claim by "bimple" of fixing and re-uploading it.
The claim by "bimple" of "I cleaned them and re-upped them.", no that didn't happen. The vulnerability is still there.